Some changes #228
Open
Some changes #228
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Update .gitignore (Add ./build) - Avoid updating event cache when redrawing the map - Increase the width of the EventDialog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
"Avoid updating event cache when redrawing the map"
After deleting this line of code, there will only be a delay during the initial map load, rather than the previous behavior where it would freeze and wait every time the map was scrolled.
"Increase the width of the EventDialog"
This is a hard-coded value, which is inconvenient for browsing events as it cannot remember the window size.
"Update .gitignore (Add ./build)"
If compiled this way, a build folder will be created. Can the build folder be ignored?